[PATCH 0/3] iproto: allow to configure IPROTO_MSG_MAX

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Sat Apr 21 01:52:08 MSK 2018

Branch: http://github.com/tarantool/tarantool/tree/gh-3320-config-msg-max
Issue: https://github.com/tarantool/tarantool/issues/3320

IPROTO_MSG_MAX is a constant that restricts count of requests in fly. It allows
to do not produce too many fibers in TX thread, that would lead to too big
overhead on fibers switching, their stack storing.

But some users have powerful metal on which Tarantool IPROTO_MSG_MAX constant is
not serious. The patch exposes it as a configuration runtime parameter.

'iproto_msg_max' is its name. If a user sees that IProto thread is stuck due to
too many requests, it can change iproto_msg_max in runtime, and IProto thread
immediately starts processing pending requests.

'iproto_msg_max' can be decreased, but obviously it can not stop already runned
requests, so if now in IProto thread request count is > new 'iproto_msg_max'
value, then it takes some time until some requests will be finished.

In the same patchset a bug is fixed with incorrect discarding long-poll requests
input. Discard just calls iproto_resume() trying to notify libev, that is can
get new data. But is makes no sense, because iproto_resume() continues only
connections stopped due to reached limit of maximal requests in fly, but not
connections whose buffer is overflowed. Such stopped connections can be
continued only after a request is complete.

To continue read from the connection whose buffer was freed by discarding
long-poll it is necessary to explicitly feed to it EV_READ event. On this event iproto_connection_on_input will read a blocked data if it exists.

Vladislav Shpilevoy (3):
  iproto: rename iproto_bind_msg to iproto_cfg_msg
  iproto: fix error with input discarding
  iproto: allow to configure IPROTO_MSG_MAX

 src/box/box.cc                  |   7 ++
 src/box/box.h                   |   1 +
 src/box/iproto.cc               |  79 ++++++++++----
 src/box/iproto.h                |   3 +
 src/box/lua/cfg.cc              |  12 +++
 src/box/lua/load_cfg.lua        |   3 +
 test/app-tap/init_script.result |  73 ++++++-------
 test/box/admin.result           |   2 +
 test/box/cfg.result             |  24 +++++
 test/box/cfg.test.lua           |   9 ++
 test/box/request_limit.result   | 229 ++++++++++++++++++++++++++++++++++++++++
 test/box/request_limit.test.lua | 114 ++++++++++++++++++++
 12 files changed, 500 insertions(+), 56 deletions(-)
 create mode 100644 test/box/request_limit.result
 create mode 100644 test/box/request_limit.test.lua

2.15.1 (Apple Git-101)

More information about the Tarantool-patches mailing list