[tarantool-patches] [PATCH 0/4] sql: refactor insertion and lua

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Tue Apr 3 18:34:11 MSK 2018


Branch: http://github.com/tarantool/tarantool/tree/gh-2618-preliminary-patches
Issue: https://github.com/tarantool/tarantool/issues/2618

The patchset consists of patches preliminary to SQL IProto
"last updated tuple" introduction. It is possible, that its
implementation plan will be changed several times, but this
patchset looks useful even with no IProto "last updated tuple".

1) The patch does SQL INSERT/UPDATE refactoring by removal of 2
unused VDBE parameters, and by restyling of final insertion
opcodes generator: sqlite3CompleteInsertion.

2) The patch does refactoring of Lua SQL executor, that is
extremely overengineered now.

Vladislav Shpilevoy (4):
  sql: remove unused opcodes from OP_[Sorter/Idx][Insert/Replace]
  sql: remove unused error codes, use enum instead of defines
  sql: simplify lua SQL executor
  sql: remove useless branching in insertOrReplace

 src/box/lua/sql.c       | 239 +++++++-----------------------------------------
 src/box/sql.c           |  18 ++--
 src/box/sql/analyze.c   |   8 +-
 src/box/sql/build.c     |   4 -
 src/box/sql/delete.c    |   2 +-
 src/box/sql/expr.c      |   5 +-
 src/box/sql/insert.c    |  80 ++++------------
 src/box/sql/main.c      |  32 -------
 src/box/sql/os_unix.c   |   9 +-
 src/box/sql/select.c    |  29 +++---
 src/box/sql/sqliteInt.h | 102 +++++++++++++--------
 src/box/sql/trigger.c   |   3 +-
 src/box/sql/update.c    |   6 +-
 src/box/sql/vdbe.c      |  10 +-
 src/box/sql/vdbeInt.h   |   5 +-
 src/box/sql/vdbeapi.c   |   9 --
 src/box/sql/vdbeaux.c   |   1 -
 src/box/sql/wherecode.c |   5 +-
 18 files changed, 152 insertions(+), 415 deletions(-)

-- 
2.14.3 (Apple Git-98)





More information about the Tarantool-patches mailing list