[tarantool-patches] Re: [PATCH v3 3/3] Lua: implement json path access to tuple fields
Vladislav Shpilevoy
v.shpilevoy at tarantool.org
Mon Apr 16 13:02:20 MSK 2018
Hello.
>
> Thanks. The patch looks good to me now.
>
> There's one thing: the hunk below doesn't belong to this patch.
> Obviously, it should be a part of the previous patch. Please move
> it there before pushing it to the trunk.
Done on the branch.
>
> diff --git a/test/unit/json_path.result b/test/unit/json_path.result
> index 9b4ea641..a2a2f829 100644
> --- a/test/unit/json_path.result
> +++ b/test/unit/json_path.result
> @@ -1,7 +1,7 @@
> *** main ***
> 1..2
> *** test_basic ***
> - 1..67
> + 1..71
> ok 1 - parse <[0]>
> ok 2 - <[0]> is num
> ok 3 - <[0]> is 0
> @@ -46,29 +46,33 @@
> ok 42 - <field1> is str
> ok 43 - len is 6
> ok 44 - str is field1
> - ok 45 - parse <[1234]>
> - ok 46 - <[1234]> is num
> - ok 47 - <[1234]> is 1234
> - ok 48 - parse empty path
> - ok 49 - is str
> - ok 50 - parse <field1>
> - ok 51 - <field1> is str
> - ok 52 - len is 6
> - ok 53 - str is field1
> - ok 54 - parse <[2]>
> - ok 55 - <[2]> is num
> - ok 56 - <[2]> is 2
> - ok 57 - parse <[6]>
> - ok 58 - <[6]> is num
> - ok 59 - <[6]> is 6
> - ok 60 - parse <привет中国world>
> - ok 61 - <привет中国world> is str
> - ok 62 - len is 23
> - ok 63 - str is привет中国world
> - ok 64 - parse <中国a>
> - ok 65 - <中国a> is str
> - ok 66 - len is 7
> - ok 67 - str is 中国a
> + ok 45 - parse <field1>
> + ok 46 - <field1> is str
> + ok 47 - len is 6
> + ok 48 - str is field1
> + ok 49 - parse <[1234]>
> + ok 50 - <[1234]> is num
> + ok 51 - <[1234]> is 1234
> + ok 52 - parse empty path
> + ok 53 - is str
> + ok 54 - parse <field1>
> + ok 55 - <field1> is str
> + ok 56 - len is 6
> + ok 57 - str is field1
> + ok 58 - parse <[2]>
> + ok 59 - <[2]> is num
> + ok 60 - <[2]> is 2
> + ok 61 - parse <[6]>
> + ok 62 - <[6]> is num
> + ok 63 - <[6]> is 6
> + ok 64 - parse <привет中国world>
> + ok 65 - <привет中国world> is str
> + ok 66 - len is 23
> + ok 67 - str is привет中国world
> + ok 68 - parse <中国a>
> + ok 69 - <中国a> is str
> + ok 70 - len is 7
> + ok 71 - str is 中国a
> ok 1 - subtests
> *** test_basic: done ***
> *** test_errors ***
>
More information about the Tarantool-patches
mailing list