[PATCH 12/12] vinyl: allow to modify key definition if it does not require rebuild

Konstantin Osipov kostja at tarantool.org
Thu Apr 5 17:32:09 MSK 2018


I'm pushing this patch, but I dislike the strong similarity of two
msgpack keys in vylog (VY_LOG_MODIFY_LSM and
VY_LOG_KEY_MODIFY_LSN).

Please find a name to distance the two keys from each other in the
way they named, so it's harder to mistake one for another.

* Vladimir Davydov <vdavydov.dev at gmail.com> [18/04/02 11:49]:

> +	VY_LOG_KEY_MODIFY_LSN		= 13,
>  };
>  
>  /** vy_log_key -> human readable name. */
> @@ -98,6 +99,7 @@ static const char *vy_log_key_name[] = {
>  	[VY_LOG_KEY_GC_LSN]		= "gc_lsn",
>  	[VY_LOG_KEY_TRUNCATE_COUNT]	= "truncate_count",
>  	[VY_LOG_KEY_CREATE_LSN]		= "create_lsn",
> +	[VY_LOG_KEY_MODIFY_LSN]		= "modify_lsn",
>  };
>  
>  /** vy_log_type -> human readable name. */
> @@ -115,6 +117,7 @@ static const char *vy_log_type_name[] = {
>  	[VY_LOG_DUMP_LSM]		= "dump_lsm",
>  	[VY_LOG_SNAPSHOT]		= "snapshot",
>  	[VY_LOG_TRUNCATE_LSM]		= "truncate_lsm",
> +	[VY_LOG_MODIFY_LSM]		= "modify_lsm",
>  };

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov



More information about the Tarantool-patches mailing list