[tarantool-patches] Re: [PATCH 1/3] sql: remove usless #ifdef directives

[Vladislav Shpilevoy]

Hello. Please consider a single comment: remove SQLITE_OMIT_VIEW from 
mkkeywordhash.c.

Other comments I will give to a next patch version, as we discussed 
verbally.


03.04.2018 17:54, Nikita Pettik пишет:
> Since in our SQL implemetation triggers, foreign keys and views are
> always available, there is no need in #ifdef directives which
> turn them off.
> Removed: SQLITE_OMIT_VIEW, SQLITE_OMIT_TRIGGER, SQLITE_OMIT_FOREIGN_KEY
> defines. Also, removed obsolete compelete.c source file.
> ---
>   src/box/sql/CMakeLists.txt |   1 -
>   src/box/sql/alter.c        |   2 -
>   src/box/sql/attach.c       |   6 -
>   src/box/sql/build.c        |  20 ---
>   src/box/sql/complete.c     | 333 ---------------------------------------------
>   src/box/sql/delete.c       |  18 ---
>   src/box/sql/expr.c         |   5 +-
>   src/box/sql/fkey.c         |   8 --
>   src/box/sql/insert.c       |  15 --
>   src/box/sql/parse.c        | 320 +++++++++++++++++++++----------------------
>   src/box/sql/parse.y        |   7 -
>   src/box/sql/pragma.c       |   8 --
>   src/box/sql/pragma.h       |   8 --
>   src/box/sql/resolve.c      |   3 -
>   src/box/sql/select.c       |  20 ++-
>   src/box/sql/sqliteInt.h    |  39 ------
>   src/box/sql/treeview.c     |   2 -
>   src/box/sql/trigger.c      |   3 -
>   src/box/sql/update.c       |  15 --
>   src/box/sql/vdbe.c         |   5 -
>   src/box/sql/vdbe.h         |   2 -
>   src/box/sql/vdbeInt.h      |   4 -
>   src/box/sql/vdbeaux.c      |   4 -
>   23 files changed, 169 insertions(+), 679 deletions(-)
>   delete mode 100644 src/box/sql/complete.c
>