[tarantool-patches] Re: [PATCH v2] Fix warnings

[Alexander Turenko]

Hi Gleb!

LGTM.

Nikita, can you see the patch?

WBR, Alexander Turenko.

On Thu, Apr 12, 2018 at 04:50:10PM +0300, Gleb wrote:
> Ensure -Werror -Wall set for the whole src/.
> Fix warnings which have been find with -Werror and -Wall.
> Add new building target RelWithDebInfoWError.
> Change building target on RelWithDebInfoWError in CI.
> 
> Fixes #3238
> ---
> Issue from https://github.com/tarantool/tarantool/issues/3238.
> Source from https://github.com/tarantool/tarantool/tree/gh-3238-check-warnings.
>  .travis.mk                 |  4 ++--
>  cmake/compiler.cmake       |  8 +++++++-
>  src/box/space_def.c        |  2 ++
>  src/box/sql/CMakeLists.txt |  3 ---
>  src/box/sql/alter.c        |  1 +
>  src/box/sql/insert.c       |  4 +++-
>  src/box/sql/pragma.c       |  4 ++--
>  src/box/vy_read_iterator.c |  2 +-
>  src/box/xrow.c             | 10 +++++++---
>  src/httpc.c                |  2 +-
>  src/lua/init.c             |  3 ++-
>  src/say.c                  |  7 +++++--
>  12 files changed, 33 insertions(+), 17 deletions(-)

>  	case SAY_LOGGER_BOOT:
>  	{
>  		ssize_t r = safe_write(STDERR_FILENO, buf, total);
>  		(void) r;                       /* silence gcc warning */
> +
>  		break;
>  	}
>  	default:
> -- 
> 2.7.4

This change (extra empty line) is redundant.