[tarantool-patches] Re: [PATCH 0/4] sql: refactor insertion and lua

[Kirill Yukhin]

Hello Vlad,
On 03 апр 18:34, Vladislav Shpilevoy wrote:
> Branch: http://github.com/tarantool/tarantool/tree/gh-2618-preliminary-patches
> Issue: https://github.com/tarantool/tarantool/issues/2618
> 
> The patchset consists of patches preliminary to SQL IProto
> "last updated tuple" introduction. It is possible, that its
> implementation plan will be changed several times, but this
> patchset looks useful even with no IProto "last updated tuple".
> 
> 1) The patch does SQL INSERT/UPDATE refactoring by removal of 2
> unused VDBE parameters, and by restyling of final insertion
> opcodes generator: sqlite3CompleteInsertion.
> 
> 2) The patch does refactoring of Lua SQL executor, that is
> extremely overengineered now.
> 
> Vladislav Shpilevoy (4):
>   sql: remove unused opcodes from OP_[Sorter/Idx][Insert/Replace]
>   sql: remove unused error codes, use enum instead of defines
>   sql: simplify lua SQL executor
>   sql: remove useless branching in insertOrReplace
The patchset LGTM. I've comitted it to 2.0

--
Regards, Kirill Yukhin