[tarantool-patches] Re: [PATCH 0/2] rework SQL 'DROP' routine

Kirill Yukhin kyukhin at tarantool.org
Thu Apr 5 17:12:30 MSK 2018

Hello Nikita,
On 03 апр 19:14, Nikita Pettik wrote:
> Branch: https://github.com/tarantool/tarantool/tree/np/gh-3222-rework-drop
> Issue: https://github.com/tarantool/tarantool/issues/3222
> This small patch-set implements part of #3222 issue: rewrite functions
> implementing drop table and drop index in order to avoid using
> struct Table and its lookup in SQLite data-dictionary.
> However, as far as currently triggers aren't part of Tarantool's spaces,
> it is still required to use struct Table to drop them:
> triggers are held in _trigger space, which format is: ['name', 'sql'],
> i.e. there is no field for name of parent table. Hence, we are able
> to point out table's triggers only via accessing struct Table.
> Both patches are mainly about refactoring.
> First patch removes useless wrappers, obsolete SQLite specific functions
> and struct fields.
> Second one replaces usages of struct Table with struct space in drop
> routine, fixes codestyle, provides doxygen style comments.
> Nikita Pettik (2):
>   sql: remove obsolete SQLite routine
>   sql: rework 'DROP INDEX' and 'DROP TABLE' handling
Patchset looks perfect now, I've checked it into 2.0.

Regards, Kirill Yukhin

More information about the Tarantool-patches mailing list