[PATCH 1/1] identifier: do not use ICU UConverter for checks
Vladimir Davydov
vdavydov.dev at gmail.com
Fri Apr 6 16:53:02 MSK 2018
This doesn't work on EL6/7 and Debian Wheezy - check out travis.
https://travis-ci.org/tarantool/tarantool/builds/362116299?utm_source=github_status&utm_medium=notification
On Wed, Apr 04, 2018 at 03:35:41PM +0300, Vladislav Shpilevoy wrote:
> I makes no sense to create a converter, when there is
> nothing to convert. To check an identifier it is
> enough to use stateless ICU macros: U8_NEXT_OR_FFFD,
> that also allows to eliminate 0xFFFD symbol as a
> special one - this macros returns this code on any
> error, or when it is actually this symbol.
> ---
> Branch: https://github.com/tarantool/tarantool/tree/identifier-do-not-use-uconverter
>
> src/box/box.cc | 2 --
> src/box/identifier.c | 51 ++++++++++-----------------------------------
> src/box/identifier.h | 13 ------------
> test/unit/vy_point_lookup.c | 2 --
> 4 files changed, 11 insertions(+), 57 deletions(-)
More information about the Tarantool-patches
mailing list