[patches] [PATCH 0/2] sql: SQL bindings refactoring

[Vladislav Shpilevoy]

LGTM.

On 11/04/2018 21:23, Nikita Pettik wrote:
> Branch: https://github.com/tarantool/tarantool/tree/np/gh-3332-format-leak-fix
> Issue: https://github.com/tarantool/tarantool/issues/3332
> 
> First patch introduces fix for leaked tuple formats: under certain
> circumstances (described in commit message) some tuples from ephemeral
> space may remain referenced after space's death and as a result, format
> can't be destroyed.
> 
> Second patch consists of slight refactoring of cursor closing routine.
> 
> Nikita Pettik (2):
>    sql: fix tuple format leak
>    sql: refactor cursor closing routine
> 
>   src/box/sql.c                                   | 60 +++++++++++--------------
>   src/box/sql/cursor.c                            | 46 ++++++++++---------
>   src/box/sql/cursor.h                            |  6 ++-
>   src/box/sql/tarantoolInt.h                      |  8 ++--
>   src/box/sql/vdbe.c                              | 35 +++++----------
>   src/box/sql/vdbeaux.c                           |  2 +-
>   test/sql-tap/gh-3332-tuple-format-leak.test.lua | 31 +++++++++++++
>   7 files changed, 101 insertions(+), 87 deletions(-)
>   create mode 100755 test/sql-tap/gh-3332-tuple-format-leak.test.lua
>