[tarantool-patches] [PATCH 0/2] netbox: reuse _request() to do SQL execute()

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Thu Apr 5 22:28:08 MSK 2018

Branch: http://github.com/tarantool/tarantool/tree/gh-3323-3322-sql-iproto-schema-change
Issue: https://github.com/tarantool/tarantool/issues/3323
Issue: https://github.com/tarantool/tarantool/issues/3322

_request() is a wrapper for perform_request, that detects schema
changes, and waits until it is reloaded. Lets use _request()
instead of direct perform_request() for execute(). The reason why
the _request() was not used earlier was my attempt to avoid
multiple return values in _request(), that leads to minor fixes
in non-execute methods like index.select or eval/call_16, which
return the _request() directly.

But diplicating schema reloading logic for execute() is worse.

Vladislav Shpilevoy (2):
  netbox: forbid conn:timeout():execute(...)
  netbox: reuse _request() to do SQL execute()

 src/box/lua/net_box.lua   | 77 +++++++++++++++++++++++------------------------
 test/box/net.box.result   |  5 +--
 test/box/net.box.test.lua |  5 +--
 test/sql/iproto.result    | 45 ---------------------------
 test/sql/iproto.test.lua  | 15 ---------
 5 files changed, 44 insertions(+), 103 deletions(-)

2.14.3 (Apple Git-98)

More information about the Tarantool-patches mailing list