[Tarantool-discussions] [RFC luajit v3] rfc: describe a LuaJIT memory profiler

[Igor Munkin]

Sergey,

Thanks for the fixes, LGTM.

On 20.01.21, Sergey Kaplun wrote:
> Hi, Igor!
> 
> Thanks for the review!
> 
> On 15.01.21, Igor Munkin wrote:
> > Sergey,
> > 
> > Thanks for the changes. There is a bit of nitpicking below and I
> > believe we'll push the next version doc to the trunk.
> 
> I've fixed all your comments, plus added some insignificant fixes.
> See two iterative patches below. Branch is force pushed.

Great, thanks! I also changed the commit subject to the following:
| rfc: describe a LuaJIT memory profiler toolchain

> 
> > 
> > On 25.12.20, Sergey Kaplun wrote:
> > > Part of #5442
> > > ---
> > > 
> > > RFC on branch: https://github.com/tarantool/tarantool/blob/skaplun/gh-5442-luajit-memory-profiler/doc/rfc/5442-luajit-memory-profiler.md
> 
> Side note: branch name is updated.
> New RFC version: https://github.com/tarantool/tarantool/blob/skaplun/gh-5442-luajit-memory-profiler-rfc/doc/rfc/5442-luajit-memory-profiler.md
> 
> > > 
> > > Changes in v3:
> > > * More comments in example.
> > > * More verbose benchmark information.
> > > * Grammar and spelling fixes.
> > > 
> > > Changes in v2:
> > > * Removed C API, Tarantool integration and description of additional
> > >   features -- they will be added in another RFC if necessary.
> > > * Removed checking profile is running from the public API.
> > > * Added benchmarks and more meaningful example.
> > > * Grammar fixes.
> > > 
> > >  doc/rfc/5442-luajit-memory-profiler.md | 314 +++++++++++++++++++++++++
> > >  1 file changed, 314 insertions(+)
> > >  create mode 100644 doc/rfc/5442-luajit-memory-profiler.md
> > > 

<snipped>

> -- 
> Best regards,
> Sergey Kaplun

-- 
Best regards,
IM