[server-dev] [RFC] Interactive transactions in IProto

[Vladimir Davydov]

On Wed, Nov 14, 2018 at 09:40:44PM +0300, Vladislav Shpilevoy wrote:
> 
> 
> On 14/11/2018 20:43, Vladimir Davydov wrote:
> > On Wed, Nov 14, 2018 at 06:25:30PM +0300, Konstantin Osipov wrote:
> > > * Vladimir Davydov <vdavydov.dev at gmail.com> [18/11/13 20:51]:
> > > >   6. If IPROTO_STREAM_ID is unset (0), everything works as before, i.e.
> > > >      no transaction preservation or request serialization will occur.
> > > 
> > > I think this is a bit confusing. Logically they all must belong to
> > > stream id 0, but suddenly they all belong to (internally) distinct
> > > streams. What if I do begin on the client without an assigned
> > > stream id? Will I have a stream created automatically? What if I
> > > do a commit for a non-existent stream id?
> > 
> > IMO stream id 0 means no streaming and hence no interactive
> > transactions.
> > 
> 
> Maybe it is better to do not send IPROTO_STREAM_ID at all when no
> streaming?

Yeah, absolutely. That's what I actually meant. AFAIR 0 is equivalent to
the absence of any value in terms of iproto.